Candidate for the v0.8.7 release tag #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aarongreig
commented
Feb 9, 2024
•
aarongreig
commented
- [L0] move platform cache into the adapter structure #1252
- [L0] move adapter init into its constructor from urAdapterGet #1321
- [L0] Allocate event pools efficiently in multi-device scenarios #1324
- Update CMake version
[L0] move platform cache into the adapter structure
…ructor [L0] move adapter init into its constructor from urAdapterGet
aarongreig
force-pushed
the
aaron/v0.8.7rc
branch
3 times, most recently
from
9e448cf
to
3921683
Compare
aarongreig
force-pushed
the
aaron/v0.8.7rc
branch
from
cf8c9bc
to
b41e7fc
Compare
[L0] Allocate event pools efficiently in multi-device scenarios
aarongreig
force-pushed
the
aaron/v0.8.7rc
branch
3 times, most recently
from
40cf72f
to
8269548
Compare
aarongreig
force-pushed
the
aaron/v0.8.7rc
branch
from
8269548
to
3aeccac
Compare
kbenzie
approved these changes
Feb 12, 2024
|
@oneapi-src/unified-runtime-level-zero-write @oneapi-src/unified-runtime-command-buffer-write please review |
EwanC
approved these changes
Feb 12, 2024
nrspruit
approved these changes
Feb 12, 2024
againull
reviewed
Feb 12, 2024
Comment on lines
-757
to
+764
| UR_CALL(Queue->Context->getAvailableCommandList(Queue, SignalCommandList, | ||
| false, false)); | ||
|
|
||
| UR_CALL(createEventAndAssociateQueue(Queue, &RetEvent, | ||
| UR_COMMAND_COMMAND_BUFFER_ENQUEUE_EXP, | ||
| SignalCommandList, false)); | ||
| UR_CALL(createEventAndAssociateQueue( | ||
| Queue, &RetEvent, UR_COMMAND_COMMAND_BUFFER_ENQUEUE_EXP, | ||
| SignalCommandList, false, false, true)); |
There was a problem hiding this comment.
Merge conflict was resolved incorrectly here. getAvailableCommandList should have been left as is. Only createEventAndAssociateQueue should have been changed accordingly.
Please see againull@f9ac087#diff-ab021f9451ccb6dd66e3df853d0e123b2f898233a1f609b1e698bef4f6011c71R762-R767
for the reference.
graph tests are failing because of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.