Explicitly define which info queries are optional. #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've included 08f14c1 in this because there's a bit of bilateral interdependence going on, if we merged either those changes or the ones from the original commit from this PR separately we'd need to fix some stuff twice, like it would mean writing more code that then just gets immediately reverted. I can split them up again if necessary. |
aarongreig
force-pushed
the
aaron/optionalInfoQueries
branch
from
08f14c1
to
076d1e5
Compare
kbenzie
added
conformance
aarongreig
added a commit
to aarongreig/unified-runtime
that referenced
this pull request
May 7, 2024
This was improperly implemented and should have been reporting UNSUPPORTED. This will be properly fixed in the test by oneapi-src#1332
aarongreig
force-pushed
the
aaron/optionalInfoQueries
branch
2 times, most recently
from
479b60b
to
c4bc178
Compare
This is now reflected in the spec and in the CTS tests.
aarongreig
force-pushed
the
aaron/optionalInfoQueries
branch
from
59552ff
to
ebf7c11
Compare
aarongreig
force-pushed
the
aaron/optionalInfoQueries
branch
from
361400b
to
1c0a2ce
Compare
kbenzie
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now reflected in the spec and in the CTS tests.
Also implement a few trivial fixes for adapters failing the now enforced non-optional queries.