Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIP][CUDA][Command-Buffer] Fix Coverity issues in HIP/CUDA command-buffer code #1340

Merged
merged 3 commits into from
Mar 10, 2024
Merged

[HIP][CUDA][Command-Buffer] Fix Coverity issues in HIP/CUDA command-buffer code #1340

merged 3 commits into from
Mar 10, 2024

Commits on Mar 4, 2024

  1. [EXP][Command-Buffer] Fix CUDA Coverity issues 

    Address issues in the CUDA adapter code added by oneapi-src#1089
flagged by Coverity.

* Uninitalized struct member of `CUDA_KERNEL_NODE_PARAMS` struct
* copying instead of moving a shared pointer to a node when
  constructing a command-handle.
    @EwanC
    EwanC committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b1a32ba View commit details
    Browse the repository at this point in the history

  2. Only destroy executable graph if command-buffer finalized

    @EwanC
    EwanC committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    273ac6b View commit details
    Browse the repository at this point in the history

  3. [HIP][CMD-BUF] HIP coverity fixes 

    * Don't throw from constructor
* Move rather than copy nodes during sync-point registration
* Initalize `NextSyncPoint`
    @EwanC
    EwanC committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    be622e7 View commit details
    Browse the repository at this point in the history