Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceSanitizer] Support detecting out-of-bounds error on DeviceGlobals #1354

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

zhaomaosu
Copy link
Contributor

@zhaomaosu zhaomaosu commented Feb 18, 2024

*Fix event lists are not correctly passed to KernelLaunch

intel/llvm PR: intel/llvm#12753

@zhaomaosu zhaomaosu marked this pull request as ready for review February 18, 2024 01:59
@zhaomaosu zhaomaosu requested a review from a team as a code owner February 18, 2024 01:59
@AllanZyne AllanZyne self-requested a review February 18, 2024 06:15
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 99 lines in your changes are missing coverage. Please review.

Project coverage is 12.52%. Comparing base (78ef1ca) to head (767cfd1).
Report is 61 commits behind head on main.

Files Patch % Lines
...ource/loader/layers/sanitizer/asan_interceptor.cpp 0.00% 56 Missing ⚠️
source/loader/layers/sanitizer/ur_sanddi.cpp 0.00% 24 Missing ⚠️
...ource/loader/layers/sanitizer/asan_interceptor.hpp 0.00% 14 Missing ⚠️
...oader/layers/sanitizer/device_sanitizer_report.hpp 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1354      +/-   ##
==========================================
- Coverage   14.82%   12.52%   -2.31%     
==========================================
  Files         250      239      -11     
  Lines       36220    35919     -301     
  Branches     4094     4075      -19     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    31417     +617     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wenju-he wenju-he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AllanZyne AllanZyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbalcer
Copy link
Contributor

pbalcer commented Feb 23, 2024

please rebase and update the intel/llvm PR.

@zhaomaosu
Copy link
Contributor Author

please rebase and update the intel/llvm PR.

Done. The pre-ci of intel/llvm PR has finished, there is one windows failure which is known issue and is tracked by intel/llvm#12798. @pbalcer, could you please help merge this PR?

@pbalcer pbalcer merged commit 9b936b5 into oneapi-src:main Feb 26, 2024
52 checks passed
@zhaomaosu zhaomaosu deleted the sanitizer-device-global branch February 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants