[HIP] Check for null arg to urKernelSetArgMemObj #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/hip_nullptr
branch
from
5458368
to
cb447b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1357 +/- ##
==========================================
- Coverage 14.82% 12.72% -2.10%
==========================================
Files 250 238 -12
Lines 36220 35346 -874
Branches 4094 4010 -84
==========================================
- Hits 5369 4498 -871
- Misses 30800 30844 +44
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
EwanC
force-pushed
the
ewan/hip_nullptr
branch
2 times, most recently
from
b4d1e82
to
40845b3
Compare
aarongreig
approved these changes
Feb 19, 2024
kbenzie
added
conformance
EwanC
force-pushed
the
ewan/hip_nullptr
branch
2 times, most recently
from
d1e4a86
to
49ba55d
Compare
The Properties parameter to `urKernelSetArgMemObj` is optional, and so may be `nullptr`. However the HIP adapter assumes it is set currently. Updated this to check for nullptr, and if so assume that the buffer is read/write. Updated CTS match file so that the test executable doesn't segfault early (CTS passes nullptr properties) and more tests run but fail.
kbenzie
pushed a commit
to reble/llvm
that referenced
this pull request
Apr 11, 2024
Bump UR commit to include a bugfix for HIP UR adapter dereferencing a nullptr oneapi-src/unified-runtime#1357
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 12, 2024
Bump UR commit to include a bugfix for HIP UR adapter dereferencing a nullptr oneapi-src/unified-runtime#1357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pPropertiesparameter to urKernelSetArgMemObj is optional, and so may benullptr. However the HIP adapter assumes it is set currently. Updated this to check for nullptr, and if so assume that the buffer is read/write.Updated CTS match file so that the test executable doesn't segfault early (CTS passes nullptr properties) and more tests run but fail. Discovered during testing of #1254 and is required for those CTS tests to pass.
DPC++ PR - intel/llvm#12758