[EXP][CMDBUF] Move event reset commands to dedicated cmd-list #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DPC++ linked PR: intel/llvm#12770 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
- Coverage 14.82% 12.72% -2.11%
==========================================
Files 250 238 -12
Lines 36220 35354 -866
Branches 4094 4011 -83
==========================================
- Hits 5369 4498 -871
- Misses 30800 30852 +52
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
EwanC
approved these changes
Feb 21, 2024
EwanC
force-pushed
the
maxime/improve-L0-cmd-buffer-enqueing
branch
from
367f890
to
5e01763
Compare
Create a new command-list to reset all the events of the enqueued graph cmd. This allows us to move the enqueueing of reset commands from the command-buffer enqueue function to the finalize function, and allow us to perform this task only once. Move signal event reset from main cmd-list to reset cmd-list. Move the documentation to DPC++ design doc.
EwanC
force-pushed
the
maxime/improve-L0-cmd-buffer-enqueing
branch
from
5e01763
to
2668229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new command-list to reset all the events of the enqueued graph cmd. This allows us to move the enqueueing of reset commands from the command-buffer enqueue function to the finalize function, and allow us to perform this task only once.
Move signal event reset from main cmd-list to reset cmd-list.
Move the documentation to DPC++ design doc.