[EXP][usm p2p] Add test for ur_exp_usm_p2p and impl for hip #1369

JackAKirk · 2024-02-21T17:32:15Z

Adds USM_P2P impl for hip backend.
Introduces UR_USM_P2P_EXTENSION_STRING_EXP macro to the spec which is used to check for usm_p2p experimental extension support in UR.
The existing supported backend for this extension (CUDA) now correctly returns this device value string.
This device value string is used in the new test that is introduced to check the basic extension behavior for all implementations.

This PR matches the precedent set in #1089 for experimental extension conformance testing.

Uses the latest non deprecated hip APIs. fully tested and passing via DPC++ using Crusher. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

These changes will be made in separate PRs. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

codecov-commenter · 2024-02-21T18:09:38Z

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 12.48%. Comparing base (78ef1ca) to head (ad198f9).
Report is 153 commits behind head on main.

Files	Patch %	Lines
test/conformance/exp_usm_p2p/usm_p2p.cpp	0.00%	20 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1369      +/-   ##
==========================================
- Coverage   14.82%   12.48%   -2.34%     
==========================================
  Files         250      240      -10     
  Lines       36220    36023     -197     
  Branches     4094     4086       -8     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    31521     +721     
+ Partials       51        4      -47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

source/adapters/cuda/device.cpp

mmoadeli · 2024-02-23T10:55:27Z

include/ur_api.h

@@ -8885,6 +8885,13 @@ urUSMReleaseExp(
 #if !defined(__GNUC__)
 #pragma region usm p2p(experimental)
 #endif
+///////////////////////////////////////////////////////////////////////////////
+#ifndef UR_USM_P2P_EXTENSION_STRING_EXP
+/// @brief The extension string which defines support for USM P2P which is


I'd replace one of the twowhichs with that.

mmoadeli · 2024-02-23T11:12:21Z

scripts/core/EXP-USM-P2P.rst

+This experimental extension to the Unified-Runtime API aims to provide a
+portable interface that can call appropriate driver functions to query and
+control peer memory access within different adapters such as CUDA, HIP and
+Level Zero.



Minor change to above that you may simply ignore

Programming models like SYCL or OpenMP aim to support several important projects that utilise fine-grained peer-to-peer memory access controls. This experimental extension to the Unified-Runtime API aims to offer a portable interface capable of invoking relevant driver functions to query about and control peer memory access across various adapters, including CUDA, HIP, and Level Zero.

I'll switch the first sentence, I think this is an improvement. I think the second one is not as good as the original though.

mmoadeli · 2024-02-23T11:33:22Z

test/conformance/exp_usm_p2p/usm_p2p.cpp

+ nullptr));
+
+ std::string_view extensions_string(returned_extensions.get());
+ bool usm_p2p_support =


const bool usm_p2p_support

mmoadeli · 2024-02-23T12:43:14Z

scripts/core/EXP-USM-P2P.rst

+===========+=============================================+
+| 1.0 | Initial Draft |
+-----------+---------------------------------------------+
+| 1.1 | Added USM_P2P_EXTENSION_STRING_EXP ID Macro |


not sure if that should be revision 2.0?

I'm following other extensions that iterate through 1.1,1.2 etc. This is a minor change to the spec.

kbenzie · 2024-03-11T16:22:19Z

Please merge in the main branch so we have up to date test runs, it should also have an intel/llvm PR for testing.

JackAKirk · 2024-03-11T16:27:31Z

Please merge in the main branch so we have up to date test runs, it should also have an intel/llvm PR for testing.

I didn't add a intel/llvm PR for testing here because it doesn't affect any intel/llvm code at all. The only code anywhere that this uses is in the test that is added.
I can merge ur if you want but FYI the situation here is basically the same: no existing tests are affected by the code change.

Allow device extension queries for USM P2P support. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

JackAKirk added 6 commits January 8, 2024 11:32

USM-P2P extension implementation for hip.

0cdd69f

Uses the latest non deprecated hip APIs. fully tested and passing via DPC++ using Crusher. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Use camelCase always. Return caught UR error directly.

9bd455f

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Format.

ba74c55

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Merge branch 'main' into p2p-hip

e3a1b47

Merge branch 'main' into p2p-hip

12de78a

Revert unrelated cuda changes.

4217a2d

These changes will be made in separate PRs. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

JackAKirk requested review from a team as code owners February 21, 2024 17:32

JackAKirk requested a review from mmoadeli February 21, 2024 17:32

JackAKirk mentioned this pull request Feb 21, 2024

[HIP] USM-P2P extension implementation #1234

Closed

JackAKirk mentioned this pull request Feb 23, 2024

Tighten spec for extension queries #1374

Open

aarongreig approved these changes Feb 23, 2024

View reviewed changes

source/adapters/cuda/device.cpp Show resolved Hide resolved

mmoadeli reviewed Feb 23, 2024

View reviewed changes

mmoadeli approved these changes Feb 23, 2024

View reviewed changes

JackAKirk added the ready to merge Added to PR's which are ready to merge label Feb 23, 2024

kbenzie added the v0.9.x Include in the v0.9.x release label Mar 11, 2024

JackAKirk added 8 commits March 12, 2024 23:18

Add USM_P2P_EXTENSION_STRING_EXP Macro.

cd9a5d2

Allow device extension queries for USM P2P support. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Mark ur_exp_usm_p2p supported for CUDA.

97846c5

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Add brief Support section.

c46745e

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Add conformance test for exp_usm_p2p.

d9434c7

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Fix license header format.

1417315

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Format and fix match file name.

6288286

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Add missing .match files for all backends.

bd90079

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

Some stylistic improvements to documentation.

bcb0215

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>

kbenzie force-pushed the usm-p2p-add-test-and-macro branch from 79e2205 to bcb0215 Compare March 13, 2024 01:48

Merge branch 'p2p-hip' into usm-p2p-add-test-and-macro

f39d41f

JackAKirk requested a review from a team as a code owner March 15, 2024 09:56

JackAKirk requested a review from GeorgeWeb March 15, 2024 09:56

JackAKirk changed the title ~~[EXP][usm p2p] Add device extension value string and test for ur_exp_usm_p2p~~ [EXP][usm p2p] Add test for ur_exp_usm_p2p and impl for hip Mar 15, 2024

Merge branch 'main' into usm-p2p-add-test-and-macro

ad198f9

kbenzie merged commit 94af6e3 into oneapi-src:main Mar 18, 2024
50 checks passed

JackAKirk mentioned this pull request Jun 25, 2024

[L0] Return success on enable/disable p2p. #1786

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EXP][usm p2p] Add test for ur_exp_usm_p2p and impl for hip #1369

[EXP][usm p2p] Add test for ur_exp_usm_p2p and impl for hip #1369

JackAKirk commented Feb 21, 2024 •

edited

Loading

codecov-commenter commented Feb 21, 2024 •

edited

Loading

mmoadeli Feb 23, 2024

mmoadeli Feb 23, 2024

JackAKirk Feb 23, 2024

mmoadeli Feb 23, 2024

mmoadeli Feb 23, 2024 •

edited

Loading

JackAKirk Feb 23, 2024

kbenzie commented Mar 11, 2024

JackAKirk commented Mar 11, 2024

[EXP][usm p2p] Add test for ur_exp_usm_p2p and impl for hip #1369

[EXP][usm p2p] Add test for ur_exp_usm_p2p and impl for hip #1369

Conversation

JackAKirk commented Feb 21, 2024 • edited Loading

codecov-commenter commented Feb 21, 2024 • edited Loading

Codecov Report

mmoadeli Feb 23, 2024

Choose a reason for hiding this comment

mmoadeli Feb 23, 2024

Choose a reason for hiding this comment

JackAKirk Feb 23, 2024

Choose a reason for hiding this comment

mmoadeli Feb 23, 2024

Choose a reason for hiding this comment

mmoadeli Feb 23, 2024 • edited Loading

Choose a reason for hiding this comment

JackAKirk Feb 23, 2024

Choose a reason for hiding this comment

kbenzie commented Mar 11, 2024

JackAKirk commented Mar 11, 2024

JackAKirk commented Feb 21, 2024 •

edited

Loading

codecov-commenter commented Feb 21, 2024 •

edited

Loading

mmoadeli Feb 23, 2024 •

edited

Loading