Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document adapter logging environment variables #1376

Merged
merged 1 commit into from
May 15, 2024

Conversation

lplewa
Copy link
Contributor

@lplewa lplewa commented Feb 22, 2024

This PR is supposed to be merged along/after logger changes in adapters.
(#1359; #1347; #1345; #1342; #1032)

To prevent merge conflicts between adapter changes, I have created this PR for the documentation update. Splitting this change into commits along with the logger changes would result in needing to rebase and resolve conflicts after each PR merge, what would become cumbersome to maintain. While this approach allows for merging all changes simultaneously without any conflicts.

Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might make sense to just have a section for all these logging related variables instead of just repeating the same sentence for every adapter.

Signed-off-by: Łukasz Plewa <lukasz.plewa@intel.com>
@kbenzie kbenzie added the specification Changes or additions to the specification label Apr 10, 2024
@bratpiorka bratpiorka requested a review from kbenzie April 26, 2024 09:35
@pbalcer pbalcer merged commit 78b8e3e into oneapi-src:main May 15, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specification Changes or additions to the specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants