[urinfo] Use urDeviceGetSelected #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that oneapi-src#740 is merged, actually use `urDeviceGetSelected` in the `urinfo` tool to mirror the behaviour of the `sycl-ls` tool.
After allowing urDeviceGetSelected to return zero devices rather than returning an error, a number of unit tests started failing. This patch fixes these tests by returning the expected error code during parsing, rather than after processing all ODS terms. This has the caveat of not processing all ODS terms before reporting an error and should be revisited once more robust testing is in place.
kbenzie
force-pushed
the
benie/urinfo-ods
branch
from
d2a2fe0
to
5fe75aa
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
==========================================
- Coverage 14.82% 12.51% -2.32%
==========================================
Files 250 239 -11
Lines 36220 35952 -268
Branches 4094 4081 -13
==========================================
- Hits 5369 4498 -871
- Misses 30800 31450 +650
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
pbalcer
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #740 is merged, actually use
urDeviceGetSelectedin theurinfotool to mirror the behaviour of thesycl-lstool.