[HIP] Enable more ordering and scope capabilities for atomic memory ops #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
- Coverage 14.82% 12.51% -2.32%
==========================================
Files 250 239 -11
Lines 36220 35949 -271
Branches 4094 4076 -18
==========================================
- Hits 5369 4498 -871
- Misses 30800 31447 +647
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
GeorgeWeb
commented
May 6, 2024
GeorgeWeb
force-pushed
the
georgi/hip-atomic-memory-caps
branch
from
df1701b to
e3b256c
Compare
GeorgeWeb
force-pushed
the
georgi/hip-atomic-memory-caps
branch
from
e3b256c to
2b2b118
Compare
|
@GeorgeWeb if you could fix the merge conflict that would be great |
GeorgeWeb
force-pushed
the
georgi/hip-atomic-memory-caps
branch
from
2b2b118 to
1162eee
Compare
GeorgeWeb
force-pushed
the
georgi/hip-atomic-memory-caps
branch
from
1162eee to
08b19b2
Compare
|
@mmoadeli ping. That one may have flown under the radar - would it be possible to take a look, please? |
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPCPP changes:
(enables
sycl::memory_order::seq_cstinsycl::atomic_ref)