Main l0 adapter release lib 0 8 x #1420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
- In Windows, SYCL and UMF both define DLLMain such that a DLLMain for only the adapter's is not possible. To fix this, the L0 adapter inits the global adapter at variable init and registers an atexit teardown after refcnt == 0. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
- To handle the customer usecases, don't return uinit when the adapter is used after the adapter library has already closed. - Given the global adapter is gone, but get adapter is called, then a temp adapter struct is allocated and an ondemand atexit cleanup of this memory is registered. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
|
I didn't notice this PR so did the cherry-pick resolution myself, looks like I did the exact same conflict resolution in #1422 but with the addition of reverting the v0.8.12 change the was decided not to be included. |
|
Closing since this is done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.