Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UR][L0][Bindless] Create sampled image from image and sampler descriptors #1441

Closed

Conversation

wenju-he
Copy link
Contributor

No description provided.

@aravindksg
Copy link

@wenju-he similar to driver changes, I think we first need to finalize the interfaces first before URT implementation. is this just to test out the flow for bindless samplers? @nrspruit FYI

we also need URT JIRA to track implementation effort

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.49%. Comparing base (78ef1ca) to head (2865cd8).
Report is 190 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   14.82%   12.49%   -2.33%     
==========================================
  Files         250      239      -11     
  Lines       36220    36003     -217     
  Branches     4094     4086       -8     
==========================================
- Hits         5369     4498     -871     
- Misses      30800    31501     +701     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenju-he
Copy link
Contributor Author

I think we first need to finalize the interfaces first before URT implementation

Yes, this PR is waiting for spec change.

is this just to test out the flow for bindless samplers?

Yes. The flow for SYCL bindless sampler is working on DG2 with draft PRs. This draft PR is also intended as a formal patch when spec is changed.

we also need URT JIRA to track implementation effort

I just created a URT jira.

@kbenzie kbenzie added the level-zero L0 adapter specific issues label Apr 10, 2024
@github-actions github-actions bot added the images UR images label Apr 24, 2024
@wenju-he
Copy link
Contributor Author

This PR will be merged into #1470 when L0 spec is public and then this pr will be closed

@wenju-he
Copy link
Contributor Author

merged into #1470

@wenju-he wenju-he closed this May 14, 2024
@wenju-he wenju-he deleted the L0-SYCL-bindless-sampled-image branch May 14, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
images UR images level-zero L0 adapter specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants