[L0][Bindless Image] Fix pixel size of half type #1446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes sampling_2D_half.cpp passing on DG2.
isaacault
approved these changes
Mar 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1446 +/- ##
==========================================
- Coverage 14.82% 12.49% -2.33%
==========================================
Files 250 239 -11
Lines 36220 36003 -217
Branches 4094 4086 -8
==========================================
- Hits 5369 4498 -871
- Misses 30800 31501 +701
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
Seanst98
approved these changes
Mar 18, 2024
przemektmalon
approved these changes
Mar 18, 2024
cppchedy
approved these changes
Mar 21, 2024
DBDuncan
approved these changes
Mar 21, 2024
|
this pr is merged into #1470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sampling_2D_half.cpp passing on DG2.