[CL] Atomic fence scope capability for Intel FPGA driver #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
reviewed
Mar 15, 2024
kbenzie
force-pushed
the
benie/cl-fpga-atomic-memory-order-caps
branch
from
9f72631
to
a85eae7
Compare
aarongreig
approved these changes
Mar 19, 2024
kbenzie
force-pushed
the
benie/cl-fpga-atomic-memory-order-caps
branch
2 times, most recently
from
00b85fb
to
a811a5d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
==========================================
- Coverage 14.82% 12.46% -2.36%
==========================================
Files 250 241 -9
Lines 36220 36146 -74
Branches 4094 4097 +3
==========================================
- Hits 5369 4506 -863
- Misses 30800 31636 +836
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
kbenzie
changed the title
This patch implements a workaround for the Intel FPGA driver which is currently an OpenCL 1.2 device which also supports `UR_MEMORY_SCOPE_CAPABILITY_FLAG_DEVICE` rather than the baseline for OpenCL 1.2 devices. The workaround unconditionally queries for `CL_DEVICE_ATOMIC_FENCE_CAPABILITIES`, if it is successful the value is used. Otherwise the error code is ignored and the baseline capabilities are returned.
kbenzie
force-pushed
the
benie/cl-fpga-atomic-memory-order-caps
branch
from
a811a5d
to
6c0131f
Compare
aarongreig
pushed a commit
to kbenzie/llvm
that referenced
this pull request
Apr 5, 2024
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 5, 2024
kbenzie
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Apr 8, 2024
…memory-order-caps [CL] Atomic fence scope capability for Intel FPGA driver
19 tasks
kbenzie
added a commit
to kbenzie/llvm
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements a workaround for the Intel FPGA driver which is currently an OpenCL 1.2 device which also supports
UR_MEMORY_SCOPE_CAPABILITY_FLAG_DEVICErather than the baseline for OpenCL 1.2 devices.The workaround unconditionally queries for
CL_DEVICE_ATOMIC_FENCE_CAPABILITIES, if it is successful the value is used. Otherwise the error code is ignored and the baseline capabilities are returned.