[CTS] Modify various urEnqueueMemBuffer* conformance tests to use parameterized fixtures #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
commented
Mar 15, 2024
martygrant
commented
Mar 15, 2024
martygrant
force-pushed
the
martin/parameteriseEnqueueMemBufferTests
branch
from
5b6689a
to
4a220d2
Compare
…ameterized fixtures.
martygrant
force-pushed
the
martin/parameteriseEnqueueMemBufferTests
branch
from
4a220d2
to
6a44b93
Compare
|
Ignore the 2 failing Coverage jobs, failure appears to be random. |
aarongreig
approved these changes
Mar 27, 2024
Co-authored-by: aarongreig <aaron.greig@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new
urMemBufferQueueTestWithParamtemplate fixture to accept parameters so different values for the buffer size and type can be easily changed. This is specifically forurEnqueueMemBuffer*tests.TODO: Will need to add new match file entries for the parameterized versions of the tests so CI passes.