[CTS] Don't use mangled global variable name #1456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `urGlobalVariableTest` fixture, replace the mangled variable name with the non-mangled version. This enables the test pass on Intel OpenCL Graphis driver.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1456 +/- ##
==========================================
- Coverage 14.82% 12.46% -2.36%
==========================================
Files 250 241 -9
Lines 36220 36146 -74
Branches 4094 4097 +3
==========================================
- Hits 5369 4506 -863
- Misses 30800 31636 +836
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
|
Naming of global variables for us in this entry point is not as well defined as it should be. The SYCL requirements are apparently wider that the CUDA entry-point or (unspecified) OpenCL extension expect for reasons I do not comprehend yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
urGlobalVariableTestfixture, replace the mangled variable name with the non-mangled version. This enables the test pass on Intel OpenCL Graphis driver.