Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cmd-Buf][L0] Fix Coverity unsigned comparison report #1461

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Mar 20, 2024

Fixes Coverity defect report from L0 command-buffer update code merged in #1353

This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "CommandDesc->newWorkDim >= 0U".

DPC++ PR intel/llvm#13075

@EwanC EwanC marked this pull request as ready for review March 20, 2024 13:29
@EwanC EwanC requested a review from a team as a code owner March 20, 2024 13:33
Copy link
Contributor

@julianmi julianmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EwanC EwanC added the v0.9.x Include in the v0.9.x release label Mar 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.43%. Comparing base (78ef1ca) to head (edc1821).
Report is 199 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1461      +/-   ##
==========================================
- Coverage   14.82%   12.43%   -2.40%     
==========================================
  Files         250      241       -9     
  Lines       36220    36242      +22     
  Branches     4094     4111      +17     
==========================================
- Hits         5369     4506     -863     
- Misses      30800    31732     +932     
+ Partials       51        4      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EwanC EwanC added the ready to merge Added to PR's which are ready to merge label Mar 21, 2024
Fixes Coverity defect report from L0 command-buffer update
code merged in oneapi-src#1353

```
This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "CommandDesc->newWorkDim >= 0U".
```
@aarongreig aarongreig merged commit 6883118 into oneapi-src:main Mar 25, 2024
50 checks passed
EwanC added a commit to reble/llvm that referenced this pull request Mar 25, 2024
sarnex pushed a commit to intel/llvm that referenced this pull request Mar 25, 2024
kbenzie pushed a commit to kbenzie/unified-runtime that referenced this pull request Apr 8, 2024
[Cmd-Buf][L0] Fix Coverity unsigned comparison report
@kbenzie kbenzie mentioned this pull request Apr 16, 2024
19 tasks
kbenzie pushed a commit to kbenzie/llvm that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Added to PR's which are ready to merge v0.9.x Include in the v0.9.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants