[Spec Constants] Improved handling of invalid spec. constants #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1469 +/- ##
==========================================
- Coverage 14.82% 12.42% -2.41%
==========================================
Files 250 241 -9
Lines 36220 36271 +51
Branches 4094 4111 +17
==========================================
- Hits 5369 4506 -863
- Misses 30800 31761 +961
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
RossBrunton
force-pushed
the
ross/specconst
branch
9 times, most recently
from
3726312
to
e51fd23
Compare
aarongreig
reviewed
Mar 29, 2024
aarongreig
approved these changes
Mar 29, 2024
|
@jchlanda is our spec constants expert. Jakub, please take over this review |
jchlanda
approved these changes
Apr 2, 2024
RossBrunton
force-pushed
the
ross/specconst
branch
from
e51fd23
to
92cb04e
Compare
RossBrunton
force-pushed
the
ross/specconst
branch
from
92cb04e
to
a4019b0
Compare
RossBrunton
force-pushed
the
ross/specconst
branch
from
a4019b0
to
f362901
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 7, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
RossBrunton
force-pushed
the
ross/specconst
branch
2 times, most recently
from
0697190
to
e82bb87
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 7, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
RossBrunton
force-pushed
the
ross/specconst
branch
from
e82bb87
to
9c07bc2
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 7, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
RossBrunton
force-pushed
the
ross/specconst
branch
4 times, most recently
from
4a19308
to
429267f
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 13, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
RossBrunton
force-pushed
the
ross/specconst
branch
from
429267f
to
fe17c7f
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 14, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
RossBrunton
force-pushed
the
ross/specconst
branch
from
fe17c7f
to
92b17d9
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 14, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
RossBrunton
force-pushed
the
ross/specconst
branch
from
92b17d9
to
1a78a53
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 14, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
RossBrunton
force-pushed
the
ross/specconst
branch
2 times, most recently
from
b93c1ad
to
7538206
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 20, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
RossBrunton
force-pushed
the
ross/specconst
branch
from
7538206
to
ba9d474
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 23, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
RossBrunton
force-pushed
the
ross/specconst
branch
from
ba9d474
to
2116a3f
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 23, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
…ants Two main changes to how `Kernel/ProgramSetSpecializationConstants` are handled: * They may now output either `INVALID_VALUE` or the new `INVALID_SPEC_ID` when the provided list is invalid. * The OpenCL and level 0 adapters now respond to `UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTS` with `false` rather than erroring out. This fixes some tests that were incorrectly not being skipped. * `urKernelSetSpecializationConstants` now "implemented" (as a function that returns `UNSUPPORTED_FEATURE` for a number of adapters.
RossBrunton
force-pushed
the
ross/specconst
branch
from
2116a3f
to
9fbd4fe
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Aug 23, 2024
…onstants Pre-commit MR for oneapi-src/unified-runtime#1469
|
@RossBrunton Please rebase this when possible, I removed the ready to merge label and please readd it when rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two main changes to how
Kernel/ProgramSetSpecializationConstantsare handled:INVALID_VALUEor the newINVALID_SPEC_IDwhen the provided list is invalid.UR_DEVICE_INFO_KERNEL_SET_SPECIALIZATION_CONSTANTSwithfalserather than erroring out. This fixes some tests that were incorrectly not being skipped.urKernelSetSpecializationConstantsnow "implemented" (as a function that returnsUNSUPPORTED_FEATUREfor opencl and cuda.