[L0] fix return types for urDeviceGetInfo #1476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason
device-adapter_level_zerostarted failing on my PR: #1430 It seems that the order in which tests are executed is different on clang and on GCC, hence match files only work on one of those compilers.This PR gets rid of most of the suppressions by just returning a proper type from urDeviceGetInfo and changing UR_RESULT_ERROR_INVALID_VALUE to UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION as expected by the test.