Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NATIVECPU] Initial threadpool implementation for Native CPU #1478

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

PietroGhg
Copy link
Contributor

@PietroGhg PietroGhg commented Mar 27, 2024

This PR introduces a simple threadpool implementation that is used to execute work groups in parallel.
DPC++ PR: intel/llvm#13176

@@ -160,15 +163,22 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
case UR_DEVICE_INFO_PREFERRED_VECTOR_WIDTH_FLOAT:
case UR_DEVICE_INFO_PREFERRED_VECTOR_WIDTH_DOUBLE:
case UR_DEVICE_INFO_PREFERRED_VECTOR_WIDTH_HALF:
// TODO: How can we query vector width in a platform
// independent way?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of future PRs we could have cpu device descriptors with the option to override the individual device properties (below) with environment variables.

Copy link
Contributor

@uwedolinsky uwedolinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as the first iteration of the threadpool integration 👍

@PietroGhg PietroGhg added the ready to merge Added to PR's which are ready to merge label Apr 3, 2024
@kbenzie kbenzie added the native-cpu Native CPU adapter specific issues label Apr 3, 2024
@kbenzie kbenzie merged commit 38e9478 into oneapi-src:main Apr 11, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
native-cpu Native CPU adapter specific issues ready to merge Added to PR's which are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants