[NATIVECPU] Extended usm fill to bigger patterns than 1 byte #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroGhg
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
We are definitely gonna need this after intel/llvm#12702 goes in, thank you!
konradkusiak97
added
ready to merge
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 15, 2024
…byte (#13263) oneapi-src/unified-runtime#1489 Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The urEnqueueUSMFill command should cover the filling for any arbitrary sizes of the pattern.
I've been looking how it is implemented for all of the adapters while working on intel/llvm#12702 and thought I'll make a PR.
intel/llvm Testing: intel/llvm#13263