-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHA] Separate out hardware workflows #1530
[GHA] Separate out hardware workflows #1530
Conversation
a12f8fe
to
d68ee89
Compare
97c67b0
to
1757cf7
Compare
1757cf7
to
86cb3af
Compare
I'll try this out. I'm not 100% happy with how things got split up and displayed in my current approach either. |
86cb3af
to
cdda8c2
Compare
@lukaszstolarczuk this looks good, on here I like how the adapter jobs are also collapsable. I'm tempted to split out the other jobs in the |
One thing this approach doesn't do, which I liked about the separate workflows, is allow for retrying just the jobs for a single adapter. The whole |
ce5f2ad
to
5b9bb8e
Compare
The goal of this patch is to make a failure of one HW build & test job only cancel jobs running on the same HW tag rather than all HW jobs for all adapters. It does this by moving the hardware jobs out of the `cmake.yml` workflow into the new `build-hw-reusable.yml` workflow, which as the name suggests is reusable. This reusable workflow is then used in by adapter specific jobs in the `cmake.yml` workflow to display jobs in a group which is collapsible.
5b9bb8e
to
9cf23eb
Compare
The goal of this patch is to make a failure of one HW build & test job only cancel jobs running on the same HW tag rather than all HW jobs for all adapters. It does this by moving the hardware jobs out of the
cmake.yml
workflow into the newbuild-hw-reusable.yml
workflow, which as the name suggests is reusable. This reusable workflow is then used in by adapter specific jobs in thecmake.yml
workflow to display jobs in a group which is collapsible.