[Bindless][Exp] Add const-qualifier to Src param in urBindlessImagesImageCopyExp #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
approved these changes
Jun 11, 2024
DBDuncan
approved these changes
Jun 11, 2024
github-actions
bot
added
loader
isaacault
approved these changes
Jun 17, 2024
Seanst98
force-pushed
the
sean/copy-const-qualifiers
branch
from
dd15bfa
to
709d3bc
Compare
ProGTX
force-pushed
the
sean/copy-const-qualifiers
branch
2 times, most recently
from
3314e4e
to
2fbe4d4
Compare
Seanst98
force-pushed
the
sean/copy-const-qualifiers
branch
8 times, most recently
from
e1af8f8
to
8f9bf70
Compare
|
Friendly ping @oneapi-src/unified-runtime-level-zero-write. The failures in CI are related to #1829 and intel/llvm#14516. |
…mageCopyExp Add const-qualifier to Src parameter in urBindlessImagesImageCopyExp.
Seanst98
force-pushed
the
sean/copy-const-qualifiers
branch
from
8f9bf70
to
8ad8e38
Compare
pbalcer
approved these changes
Jul 12, 2024
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 17, 2024
Add missing const qualifiers to Src parameter in ext_oneapi_copy functions and bindless spec. This is an ABI-Breaking change not intended for merging until the ABI-Break window. Corresponding UR PR: oneapi-src/unified-runtime#1743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add const-qualifier to
Srcparameter inurBindlessImagesImageCopyExp.Corresponding DPC++ PR: intel/llvm#14140