Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DeviceSanitizer] Memory overhead statistics #1869

Merged
merged 24 commits into from
Oct 3, 2024
Merged

[DeviceSanitizer] Memory overhead statistics #1869

merged 24 commits into from
Oct 3, 2024

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Jul 17, 2024 •
edited
Loading

LLVM: intel/llvm#14592

Statistic memory overhead (usm redzone + shadow memory) on each context, enabled by exporting asan flag UR_LAYER_ASAN_OPTIONS=print_stats:1.

Addtionally, move "AsanOptions" under "SanitizerInterceptor".

@AllanZyne AllanZyne requested a review from a team as a code owner July 17, 2024 03:24
@github-actions github-actions bot added loader Loader related feature/bug sanitizer Sanitizer layer issues/changes/specification labels Jul 17, 2024
@AllanZyne AllanZyne marked this pull request as draft July 17, 2024 03:24
@AllanZyne AllanZyne mentioned this pull request Jul 17, 2024
Merged
@AllanZyne AllanZyne marked this pull request as ready for review August 28, 2024 08:57
@yingcong-wu yingcong-wu mentioned this pull request Sep 2, 2024
Closed
@yingcong-wu
Copy link
Contributor

yingcong-wu commented Sep 5, 2024 •
edited
Loading

It occurs to me that this only measures the redzone overhead, I think we should also mean the total overhead including shadow memory and other usages. Maybe we can implement a thin layer that keeps track of all memory allocation and compares the data with and without the sanitizer layer. That way we can have the overall memory overhead data instead of only the redzone overhead.

@AllanZyne
Copy link
Contributor Author

It occurs to me that this only measures the redzone overhead, I think we should also mean the total overhead including shadow memory and other usages.

No, actually it includes shadow memory.

@AllanZyne
Copy link
Contributor Author

Hi @pbalcer @kswiecicki, please review. Thanks!

pbalcer
pbalcer approved these changes Sep 13, 2024
View reviewed changes
source/loader/layers/sanitizer/asan_options.cpp Outdated Show resolved Hide resolved
@AllanZyne
Copy link
Contributor Author

Hi @pbalcer, I think the failed CIs are unrelated, could you please double check this? Thanks!

@pbalcer
Copy link
Contributor

pbalcer commented Sep 16, 2024

@AllanZyne they are indeed. I'll mark it ready to merge after you get approval from @yingcong-wu.

yingcong-wu
yingcong-wu approved these changes Sep 18, 2024
View reviewed changes
source/loader/layers/sanitizer/asan_statistics.cpp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a idea and a nit, can we create a warpper to check PrintStats, and avoid (as much as we can) the overhead of this statistics when we not enable the tracking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Done.

@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label Sep 18, 2024
@pbalcer
Copy link
Contributor

pbalcer commented Sep 19, 2024 •
edited
Loading

I resolved a conflict and rebased the PR.

... but it didn't work :-) please rebase and update the PR. Thanks.

@AllanZyne
Copy link
Contributor Author

I resolved a conflict and rebased the PR.

... but it didn't work :-) please rebase and update the PR. Thanks.

No problem. Done.

@aarongreig
Copy link
Contributor

looking to merge this soon, are @zhaomaosu and @kswiecicki still required reviewers?

zhaomaosu
zhaomaosu approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllanZyne
Copy link
Contributor Author

Kindly ping @kswiecicki

@aarongreig aarongreig merged commit 4cd2dac into oneapi-src:main Oct 3, 2024
75 of 77 checks passed
sarnex pushed a commit to intel/llvm that referenced this pull request Oct 4, 2024
@AllanZyne @kbenzie
[SYCL][E2E][DeviceSanitizer] Memory overhead statistics (#14592)
5750eaf 
UR: oneapi-src/unified-runtime#1869

Statistic memory overhead (usm redzone + shadow memory) on each context,
enabled by exporting asan flag UR_LAYER_ASAN_OPTIONS=print_stats:1.

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yingcong-wu yingcong-wu yingcong-wu approved these changes

@zhaomaosu zhaomaosu zhaomaosu approved these changes

@pbalcer pbalcer pbalcer approved these changes

@kswiecicki kswiecicki Awaiting requested review from kswiecicki

Assignees
No one assigned
Labels
loader Loader related feature/bug ready to merge Added to PR's which are ready to merge sanitizer Sanitizer layer issues/changes/specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AllanZyne @yingcong-wu @pbalcer @aarongreig @zhaomaosu @kbenzie