Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceSanitizer] Handle the case of urMemGetNativeHandle getting a nullptr Device #1969

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

yingcong-wu
Copy link
Contributor

We follow the implementation of L0 adapter and use the first device in the context instead.

@yingcong-wu yingcong-wu requested a review from a team as a code owner August 14, 2024 06:53
@github-actions github-actions bot added loader Loader related feature/bug sanitizer Sanitizer layer issues/changes/specification labels Aug 14, 2024
@yingcong-wu
Copy link
Contributor Author

Failed Tests (8):
  SYCL :: ESIMD/mask_expand_load.cpp
  SYCL :: Matrix/element_wise_all_ops_1d.cpp
  SYCL :: Matrix/element_wise_all_ops_1d_cont.cpp
  SYCL :: Matrix/element_wise_all_ops_scalar.cpp
  SYCL :: Matrix/joint_matrix_bf16_fill_k_cache_OOB.cpp
  SYCL :: Matrix/joint_matrix_bf16_fill_k_cache_prefetch.cpp
  SYCL :: Matrix/joint_matrix_out_bounds.cpp
  SYCL :: Matrix/joint_matrix_unaligned_k.cpp

Failure seems unrelated, could we rerun the job?

Copy link
Contributor

@AllanZyne AllanZyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one fix

@yingcong-wu
Copy link
Contributor Author

Failures of Fuzz tests short and Level Zero are cmake config problem:

error: pathspec 'sycl-nightly/20230703' did not match any file(s) known to git
CMake Error at /usr/share/cmake-3.22/Modules/ExternalProject.cmake:2882 (message):
  No download info given for 'xptifw-populate' and its source directory:

   /home/test-user/actions-runner/_work/unified-runtime/unified-runtime/build/content-xptifw/xptifw

  is not an existing non-empty directory.  Please specify one of:

   * SOURCE_DIR with an existing non-empty directory
   * DOWNLOAD_COMMAND
   * URL
   * GIT_REPOSITORY
   * SVN_REPOSITORY
   * HG_REPOSITORY
   * CVS_REPOSITORY and CVS_MODULE
Call Stack (most recent call first):
  /usr/share/cmake-3.22/Modules/ExternalProject.cmake:3716 (_ep_add_download_command)
  CMakeLists.txt:15 (ExternalProject_Add)

And the failure of Level Zero V2 should not be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loader Loader related feature/bug sanitizer Sanitizer layer issues/changes/specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants