Add two new properties to ur_kernel_group_info_t #1996
Merged
+243
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
github-actions
bot
added
level-zero
frasercrmck
force-pushed
the
ur-max-wg-size-props
branch
from
8165d6d
to
eb2d7d9
Compare
frasercrmck
force-pushed
the
ur-max-wg-size-props
branch
from
3b47ca3
to
b595cbf
Compare
|
LGTM but I think it'd be a good idea to add a SYCL kernel here that uses this SYCL property. |
I think that's a good idea but would depend on my DPC++ PR to be merged first, so that will have to be future work. |
hdelan
approved these changes
Aug 28, 2024
frasercrmck
changed the title
frasercrmck
force-pushed
the
ur-max-wg-size-props
branch
from
b595cbf
to
2b9c42c
Compare
PietroGhg
reviewed
Aug 29, 2024
PietroGhg
approved these changes
Sep 2, 2024
|
Ping @oneapi-src/unified-runtime-opencl-write and @oneapi-src/level-zero-maintainers, thanks |
aarongreig
approved these changes
Sep 4, 2024
|
Ping @oneapi-src/level-zero-maintainers, thanks |
pbalcer
approved these changes
Sep 10, 2024
frasercrmck
force-pushed
the
ur-max-wg-size-props
branch
from
4ac25b4
to
118a885
Compare
pbalcer
approved these changes
Sep 10, 2024
frasercrmck
force-pushed
the
ur-max-wg-size-props
branch
2 times, most recently
from
f71a91e
to
bcca15a
Compare
These two properties allow the program to specify a maximum work-group size in various ways. They are intended to be targeted from languages such as SYCL (see intel/llvm#14518). This PR implements them for CUDA and Native CPU. It should also be able support them for HIP, in the same fashion. Other adapters using SPIR-V and/or Level Zero would require further changes to both of those specifications.
frasercrmck
force-pushed
the
ur-max-wg-size-props
branch
from
bcca15a
to
6eb5208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two properties allow the program to specify a maximum work-group size in various ways.
They are intended to be targeted from languages such as SYCL (see intel/llvm#14518).
This PR implements them for CUDA and Native CPU. It should also be able support them for HIP, in the same fashion. Other adapters using SPIR-V and/or Level Zero will need further changes to both of those specifications.