[UR][hip][opencl] Mark urKernelSuggestMaxCooperativeGroupCountExp as unsupported instead of returning misleading default value #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchlanda
approved these changes
Sep 12, 2024
GeorgeWeb
force-pushed
the
georgi/unsupported-max-coop-wgsize
branch
2 times, most recently
from
609cae5
to
6eb27d5
Compare
GeorgeWeb
force-pushed
the
georgi/unsupported-max-coop-wgsize
branch
4 times, most recently
from
ca55cef
to
73ca483
Compare
aarongreig
reviewed
Sep 24, 2024
GeorgeWeb
force-pushed
the
georgi/unsupported-max-coop-wgsize
branch
3 times, most recently
from
fa515a0
to
ed6fbad
Compare
aarongreig
approved these changes
Sep 27, 2024
…unsupported instead of returning misleading default value
GeorgeWeb
force-pushed
the
georgi/unsupported-max-coop-wgsize
branch
from
ed6fbad
to
55bd563
Compare
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 10, 2024
…xceeded launch limits on more backends (hip and opencl) (#15369) The HIP and OpenCL backend implementations of the query had a default return `1` group implementation, which is an incorrect assumptions. They will now be marked as _Unsupported_ with the accompanying UR chagnes (see oneapi-src/unified-runtime#2038), so for these cases the `kernel_queue_specific::max_num_work_groups` launch query will rely on the fallback that returns either `1` or `0` groups based on hardware resource limitation checks for the kernel. --------- Co-authored-by: Aaron Greig <aaron.greig@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/llvm: intel/llvm#15369