Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Testing for multiple adapters #2082

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/build-hw-reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jobs:
]
build_type: [Debug, Release]
compiler: [{c: gcc, cxx: g++}, {c: clang, cxx: clang++}]
multiple: [Multiple, Single]
# TODO: The latest L0 loader segfaults when built with clang.
exclude:
- adapter: {name: L0, platform: ""}
Expand All @@ -57,6 +58,11 @@ jobs:
build_type: Release
- adapter: {static_adapter: ON}
compiler: {c: clang, cxx: clang++}
# With the "Multiple" jobs, don't bother with every combination
- multiple: Multiple
build_type: Release
- multiple: Multiple
compiler: {c: clang, cxx: clang++}

runs-on: ${{inputs.runner_name}}

Expand Down Expand Up @@ -89,6 +95,7 @@ jobs:
-DUR_SYCL_LIBRARY_DIR=${{github.workspace}}/dpcpp_compiler/lib
${{ matrix.adapter.name == 'HIP' && '-DUR_CONFORMANCE_AMD_ARCH=gfx1030' || '' }}
${{ matrix.adapter.name == 'HIP' && '-DUR_HIP_PLATFORM=AMD' || '' }}
${{ matrix.multiple == 'Multiple' && '-DUR_BUILD_ADAPTER_OPENCL=ON -DUR_BUILD_ADAPTER_L0=ON' || '' }}

- name: Build
# This is so that device binaries can find the sycl runtime library
Expand All @@ -97,6 +104,8 @@ jobs:
- name: Test adapter specific
working-directory: ${{github.workspace}}/build
run: ctest -C ${{matrix.build_type}} --output-on-failure -L "adapter-specific" --timeout 180
# Don't run adapter specific tests when building multiple adapters
if: ${{ matrix.multiple == 'Single' }}

- name: Test adapters
working-directory: ${{github.workspace}}/build
Expand Down
3 changes: 3 additions & 0 deletions source/loader/ur_ldrddi.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,9 @@ __urdlllocal ur_result_t UR_APICALL urDeviceGetInfo(
) {
ur_result_t result = UR_RESULT_SUCCESS;

// For testing - this should explode and fail tests
abort();

[[maybe_unused]] auto context = getContext();

// extract platform's function pointer table
Expand Down
Loading