Improvements to align CTS and Spec for Loader #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martygrant
commented
Sep 19, 2024
martygrant
commented
- Add a null pointer check for urLoaderConfigCreate
- Add a null pointer and invalid size check for urLoaderConfigGetinfo
- Add invalid size test for urLoaderConfigGetInfo
- Add reference count test for urLoaderConfigGetInfo
- Add new test for urLoaderConfigSetCodeLocationCallback
- Add new test for UR_LOADER_CONFIG_INFO_AVAILABLE_LAYERS to test the list is valid (empty or valid values)
- Updated doc wording to say no layers are enabled by default
github-actions
bot
added
loader
aarongreig
reviewed
Sep 23, 2024
aarongreig
reviewed
Sep 23, 2024
- Add a null pointer check for urLoaderConfigCreate - Add a null pointer and invalid size check for urLoaderConfigGetinfo - Add invalid size test for urLoaderConfigGetInfo - Add reference count test for urLoaderConfigGetInfo - Add new test for urLoaderConfigSetCodeLocationCallback - Add new test for UR_LOADER_CONFIG_INFO_AVAILABLE_LAYERS to test the list is valid (empty or valid values) - Updated doc wording to say no layers are enabled by default
martygrant
force-pushed
the
martin/loader-cts-spec-gap
branch
from
ddc9c22
to
1a48b0d
Compare
aarongreig
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.