[Cuda] Simplify the 'getMaxRegistersJitOptionValue' utility and its use #2110
+14
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeWeb
force-pushed
the
georgi/cuda-update-get-max-regs-jit-option-util
branch
from
1bfe742
to
9416808
Compare
GeorgeWeb
force-pushed
the
georgi/cuda-update-get-max-regs-jit-option-util
branch
from
9416808
to
f106360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the
getMaxRegistersJitOptionValuefunction as it was previously unclear what the return bool value actually meant, because it doesn't really signify whether the value was valid or not but it was more of a whether the parsing was successful.Now we just check if the parsed value is different from the default value for
CU_JIT_MAX_REGISTERSand if it is, we add it to the list of options.