Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add low-power events experimental extension spec #2253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add low-power events experimental extension spec #2253

wants to merge 1 commit into from

Conversation

pbalcer
Copy link
Contributor

@pbalcer pbalcer commented Oct 28, 2024

No description provided.

@pbalcer pbalcer requested review from a team as code owners October 28, 2024 10:38
@pbalcer pbalcer requested a review from ldrumm October 28, 2024 10:38
@github-actions github-actions bot added loader Loader related feature/bug common Changes or additions to common utilities specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues native-cpu Native CPU adapter specific issues labels Oct 28, 2024
kbenzie
kbenzie reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec file seems to be missing.

@pbalcer
Copy link
Contributor Author

pbalcer commented Oct 28, 2024

The spec file seems to be missing.

:| done.

@github-actions github-actions bot added the experimental Experimental feature additions/changes/specification label Oct 28, 2024
@pbalcer pbalcer force-pushed the low-power-events branch 2 times, most recently from a90ace6 to 7435f26 Compare October 28, 2024 11:24
steffenlarsen
steffenlarsen approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

include/ur_api.h Show resolved Hide resolved
nrspruit
nrspruit approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for L0

@pbalcer
Copy link
Contributor Author

pbalcer commented Oct 30, 2024

@oneapi-src/unified-runtime-native-cpu-write please review

@pbalcer
Copy link
Contributor Author

pbalcer commented Oct 31, 2024

@oneapi-src/unified-runtime-native-cpu-write ping

2 similar comments
@pbalcer
Copy link
Contributor Author

pbalcer commented Nov 6, 2024

@oneapi-src/unified-runtime-native-cpu-write ping

@pbalcer
Copy link
Contributor Author

pbalcer commented Nov 12, 2024

@oneapi-src/unified-runtime-native-cpu-write ping

@pbalcer pbalcer added the ready to merge Added to PR's which are ready to merge label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@PietroGhg PietroGhg PietroGhg approved these changes

@nrspruit nrspruit nrspruit approved these changes

@kbenzie kbenzie kbenzie approved these changes

@ldrumm ldrumm Awaiting requested review from ldrumm ldrumm is a code owner automatically assigned from oneapi-src/unified-runtime-hip-write

Assignees
No one assigned
Labels
common Changes or additions to common utilities cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbalcer @kbenzie @nrspruit @PietroGhg @steffenlarsen