[CMake]: Use check_linker_flag for /DEPENDENTLOADFLAG #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR oneapi-src#2100 changed the WIN32 check to check from `if(WIN32)` to checking if link.exe is used via `CMAKE_CXX_COMPILER_LINKER_ID`. This has two problems: - CMAKE_CXX_COMPILER_LINKER_ID is only supported starting with CMake 3.29, but UR still claims to CMake versions from 3.20 (`cmake_minimum_required` is called with this version). This results in the flag being silently dropped in earlier versions of CMake. - There are other linkers that also support this flag for example LLD. Using check_linker_flag resolves these issues without hard-coding a list of known linkers.
|
ping @kbenzie |
FYI I'm not a code owner for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2100 changed the WIN32 check to check from
if(WIN32)to checking if link.exe is used viaCMAKE_CXX_COMPILER_LINKER_ID. This has two problems:cmake_minimum_requiredis called with this version). This results in the flag being silently dropped in earlier versions of CMake.Using check_linker_flag resolves these issues without hard-coding a list of known linkers.