[ur] Add NONE to virtual mem access flags #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
commented
Jun 20, 2023
2 tasks
kbenzie
force-pushed
the
benie/virtual-mem-access-flags
branch
from
7a7102b
to
fb7eec5
Compare
kbenzie
changed the title
kbenzie
changed the title
Address [feedback](oneapi-src#525 (comment)) and add `UR_VIRTUAL_MEM_ACCESS_FLAG_NONE` to allow specifying no access.
kbenzie
force-pushed
the
benie/virtual-mem-access-flags
branch
from
fb7eec5
to
81c8c17
Compare
steffenlarsen
approved these changes
Jun 20, 2023
aarongreig
approved these changes
Jun 20, 2023
No worries, these things happen :) |
callumfare
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address feedback and add
UR_VIRTUAL_MEM_ACCESS_FLAG_NONEto allow specifying a no access.