Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uma] Improve reporting of pool/provider specific errors #640

Merged
merged 4 commits into from
Jun 29, 2023

Commits on Jun 27, 2023

  1. [uma] Improve reporting of pool/provider specific errors

    Memory provider:
     Remove the get_last_result function and replace it with
     get_last_error. This primary difference is the addition of
     the pError out parameter which returns a native error code
     emitted from a failed provider function which resulted in returning
     UMA_RESULT_ERROR_MEMORY_PROVIDER_SPECIFIC.
    
    Memory_pool:
     Remove the get_last_result function and replace it with
     get_last_allocation_status. For memory pool, I don't think we care
     about a pool-specific error codes. We do, however, want to know why the
     previous allocation/de-allocation failed. Memory pool allocation
     functions only return a pointer so we need an extra function
     (get_last_allocation_status) to get this information.
    igchor committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    fa8ec81 View commit details
    Browse the repository at this point in the history
  2. [uma] Improve error reporing int DisjointPool

    use get_last_allocation_error to return last error
    from allocation functions.
    igchor committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    438c0d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. [uma] simplify get_name

    by returning the name directly instead of through out param. This
    function is not allowed to fail anyway.
    igchor committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    599942a View commit details
    Browse the repository at this point in the history
  2. [uma] add umaGetLastFailedMemoryProvider

    which returns handle to the last failed provider.
    
    This makes error reporting API independent from how
    memory pool is using the providers (i.e. whether there is
    only a single provider or multiple)
    igchor committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    6f0df6c View commit details
    Browse the repository at this point in the history