[uma] rename uma to umf #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid confusion with uniform memory access.
vinser52
reviewed
Jun 29, 2023
| @@ -11,7 +11,7 @@ add_library(disjoint_pool STATIC | |||
| add_library(${PROJECT_NAME}::disjoint_pool ALIAS disjoint_pool) | |||
|
|
|||
| target_link_libraries(disjoint_pool PRIVATE | |||
| unified_memory_allocation | |||
| unified_malloc_framework | |||
There was a problem hiding this comment.
nit: would it be better to use just an acronym as the name for the produced library (e.g. libumf). And we can do it as a separate PR, because I understand that in this PR you just did regexp renaming.
vinser52
approved these changes
Jun 29, 2023
pbalcer
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid confusion with uniform memory access.