[UR][CTS] Add tests for urEnqueueDeviceGlobalRead/Write #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
commented
Jul 5, 2023
| using urEnqueueDeviceGetGlobalVariableReadTest = uur::urGlobalVariableTest; | ||
| UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urEnqueueDeviceGetGlobalVariableReadTest); | ||
|
|
||
| TEST_P(urEnqueueDeviceGetGlobalVariableReadTest, Success) { |
There was a problem hiding this comment.
I've only included 1 success case since to assert behaviour you have to use both entry-points.
| struct urGlobalVariableTest : uur::urKernelExecutionTest { | ||
| void SetUp() override { | ||
| program_name = "device_global"; | ||
| global_var = {"_Z7dev_var", 0}; |
There was a problem hiding this comment.
The mangled name here I got from inspecting the SYCL_PI_TRACE with the call - perhaps we could do something similar to the kernel_names header here - but just kept it simple for now.
fabiomestre
approved these changes
Jul 5, 2023
aarongreig
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #676
Closes #675