[UR] Extend testing of virtual memory #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
force-pushed
the
petr/669/extend-vm-testing
branch
from
e6554fa
to
302b2d7
Compare
fabiomestre
reviewed
Jul 7, 2023
veselypeta
force-pushed
the
petr/669/extend-vm-testing
branch
from
302b2d7
to
f534d4f
Compare
veselypeta
force-pushed
the
petr/669/extend-vm-testing
branch
from
f534d4f
to
0095324
Compare
aarongreig
reviewed
Jul 31, 2023
|
The UR_DEVICE_INFO_VIRTUAL_MEMORY_SUPPORT device query was added since this was opened. All tests using virtual memory should be guarded on this feature being supported or skipped otherwise. |
aarongreig
approved these changes
Jul 31, 2023
kbenzie
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests that we can you a virtual memory pointer instead of a USM pointer. In this test we enqueue a kernel with a virtual memory pointer instead of a USM pointer and using several
urUSMentry points.Closes #669