[UR] Allow compilation on apple for OpenCL support #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `MAKE_LIBRARY_NAME` macro to match the library naming scheme CMake uses when `VERSION` is specified on macOS, taking the form `lib<name>.<version>.dylib`. Enable color diagnostics for AppleClang. And disable the `CMAKE_FIND_FRAMEWORK` option so that in-tree dylibs are correctly loaded.
kbenzie
force-pushed
the
petr/support-apple
branch
from
7e135f6
to
8653be6
Compare
veselypeta
changed the title
pbalcer
approved these changes
Jul 10, 2023
kbenzie
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to support compilation on MacOS platforms to support the OpenCL adapter. DPC++ build a macos build with the opencl adapter https://github.com/intel/llvm/actions/runs/5483139737/jobs/9989162427.
I've added build steps for MacOS 12/13 platforms in out github workflows.