[ur] Allow native handles to be unsupported #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
changed the title
kbenzie
force-pushed
the
benie/unsupported-native-handles
branch
2 times, most recently
from
c2fc29f
to
c502d99
Compare
aarongreig
reviewed
Jul 18, 2023
aarongreig
approved these changes
Jul 18, 2023
martygrant
approved these changes
Jul 18, 2023
Some adapters do not map directly to Unified Runtime's set of API objects and as such are unable to support getting the underlying native handle or creating objects from native handles. This patch adds the `UR_RESULT_ERROR_UNSUPPORTED_FEATURE` to all native handle entry-points and updates the conformance tests to match.
kbenzie
force-pushed
the
benie/unsupported-native-handles
branch
from
c502d99
to
c1ee9f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some adapters do not map directly to Unified Runtime's set of API objects and as such are unable to support getting the underlying native handle or creating objects from native handles. This patch adds the
UR_RESULT_ERROR_UNSUPPORTED_FEATUREto all native handle entry-points and updates the conformance tests to match.