Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ur] Fix adapters linker script path on Linux #752

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Jul 28, 2023

Use an absolute path instead of just the filename for the
ur_adapter_<name>.map files to resolve /usr/bin/ld: cannot open linker script file errors.

Use an absolute path instead of just the filename for the
`ur_adapter_<name>.map` files to resolve `/usr/bin/ld: cannot open
linker script file` errors.
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's odd, it works on my system and in CI.

@kbenzie
Copy link
Contributor Author

kbenzie commented Jul 31, 2023

That's odd, it works on my system and in CI.

I use ninja instead of make so wondered if it was that but I also see this when using make so it must be something else but I'm drawing a blank.

@pbalcer
Copy link
Contributor

pbalcer commented Jul 31, 2023

That's odd, it works on my system and in CI.

I use ninja instead of make so wondered if it was that but I also see this when using make so it must be something else but I'm drawing a blank.

I don't think this change will break anything, so no point in wasting time. Lgtm.

@kbenzie kbenzie merged commit d582c12 into oneapi-src:adapters Jul 31, 2023
30 checks passed
@kbenzie kbenzie deleted the benie/fix-linux-adapters-map branch January 29, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants