Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NATIVECPU) added #define for device binary target #753

Merged
merged 9 commits into from
Aug 17, 2023

Conversation

uwedolinsky
Copy link
Contributor

Added missing #define UR_DEVICE_BINARY_TARGET_NATIVE_CPU. We need this to name the binary type for the DPC++ NativeCPU target.

@pbalcer
Copy link
Contributor

pbalcer commented Jul 31, 2023

Thank you for your contribution. The header files containing the unified runtime specification are generated automatically, so they must not be modified manually, as this patch proposes. See the contribution guide for more information.

@kbenzie
Copy link
Contributor

kbenzie commented Jul 31, 2023

As @pbalcer says these files are generated from the yaml description, this macro should be added here followed by building the generate target @uwedolinsky.

@uwedolinsky uwedolinsky marked this pull request as draft July 31, 2023 11:39
@uwedolinsky uwedolinsky marked this pull request as ready for review August 4, 2023 19:06
@uwedolinsky
Copy link
Contributor Author

Thanks @pbalcer and @kbenzie for the comments which (I think) are addressed now. Please could you review? Thank you!

@kbenzie kbenzie merged commit 21aaf94 into oneapi-src:main Aug 17, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants