Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR] Verify that every source file includes an appropriate license #761

Merged
merged 2 commits into from
Aug 2, 2023
Merged

[UR] Verify that every source file includes an appropriate license #761

merged 2 commits into from
Aug 2, 2023

Conversation

veselypeta
Copy link
Contributor

This PR:

  • Adds a simple check in CMake to check that every source file includes an appropriate comment listing the copyright and license notice.
  • The license should appear at the top of each file, so Cmake only reads the first 300 bytes in which it should find the keyword "SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception"

kbenzie
kbenzie reviewed Aug 1, 2023
View reviewed changes
cmake/helpers.cmake Outdated Show resolved Hide resolved
@veselypeta veselypeta force-pushed the petr/verify-license-files branch 3 times, most recently from 2f78501 to 7f1c2b3 Compare August 1, 2023 14:34
kbenzie
kbenzie approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment, not a blocker

scripts/verify_license.py Outdated Show resolved Hide resolved
@veselypeta veselypeta merged commit cf43531 into oneapi-src:main Aug 2, 2023
24 checks passed
@veselypeta veselypeta deleted the petr/verify-license-files branch August 2, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer approved these changes

@kbenzie kbenzie kbenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veselypeta @kbenzie @pbalcer