Add parameterization to USM alloc tests for testing pools. #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veselypeta
approved these changes
Aug 3, 2023
Also fix a couple of minor issues in tests: * check correct code for invalid size in GetMemAllocInfo test * fix shadowing in urUSMPoolTestWithParam fixture * ensure we allocate with a pool for UR_USM_ALLOC_INFO_POOL GetMemAllocInfo test
aarongreig
force-pushed
the
aaron/testUSMPools
branch
from
40a7789
to
140fb05
Compare
… test Instead this is now a separate case in USMPoolCreate Also zero initialize pools in pool fixture
igchor
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix a couple of minor issues in tests:
Addresses #738