Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UR] Check for if handle when type is complete #784

Closed
wants to merge 1 commit into from
Closed

[UR] Check for if handle when type is complete #784

wants to merge 1 commit into from

Conversation

veselypeta
Copy link
Contributor

This PR:

@veselypeta
[UR] Check for if handle when type is complete
3b829ee 
[UR] Remove is_type_complete check
@veselypeta
Copy link
Contributor Author

Actually this won't work because of the generator check. It might be possible to merge upto the latest commit provided it does not affect the cuda/hip adapters...

@pbalcer
Copy link
Contributor

pbalcer commented Aug 8, 2023

I'm worried it might conflict with a lot of things... If this is blocking you, for now I'd suggest just leaving is_type_complete_v with a comment. We can fix it later once sycl pulls in the newer ur tag.

@veselypeta veselypeta closed this Aug 8, 2023
@veselypeta veselypeta deleted the petr/cherry-pick branch August 8, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veselypeta @pbalcer