Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[loader] Add use of threads so -lpthread works when building #797

Merged
merged 6 commits into from
Aug 16, 2023
Merged

[loader] Add use of threads so -lpthread works when building #797

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a4317e
Add use of threads so -lpthread works when building
hdelan Aug 11, 2023
7be3166
Use autogenerated tools
hdelan Aug 11, 2023
10d7714
Add anonymous namespace
hdelan Aug 15, 2023
989c0e8
Undo code changes and add fix in cmake
hdelan Aug 15, 2023
b261fd9
Add required
hdelan Aug 16, 2023
5c7c60b
Only add flag if using pthreads
hdelan Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions source/loader/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,14 @@ if (UNIX)
set(THREADS_PREFER_PTHREAD_FLAG TRUE)
find_package(Threads REQUIRED)
target_link_libraries(ur_loader PRIVATE Threads::Threads)
# Older gcc versions need -pthread, not just -lpthread
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 11.1)
if(CMAKE_USE_PTHREADS_INIT)
target_link_libraries(ur_loader PRIVATE "-pthread")
endif()
endif()
endif()
endif()

if(WIN32)
Expand Down