-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct level of indirection used in KernelSetArgPointer calls. #805
Correct level of indirection used in KernelSetArgPointer calls. #805
Conversation
I was able to properly test this on more than just cuda this morning and I can confirm this will need a small patch for the cuda and opencl adapters when it gets into intel-llvm. Maybe merging this should wait until the adapters move in here and they can be patched simultaneously? |
That makes sense, convert this to draft so we don't merge it unintentionally. |
bface7e
to
740f676
Compare
740f676
to
1178193
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
=======================================
Coverage 15.72% 15.72%
=======================================
Files 223 223
Lines 31475 31475
Branches 3557 3557
=======================================
Hits 4951 4951
Misses 26473 26473
Partials 51 51 ☔ View full report in Codecov by Sentry. |
1de74d7
to
1c7d0c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for level zero
@oneapi-src/unified-runtime-native-cpu-write @mmoadeli would be great to get your reviews on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native CPU lgtm, thank you
@oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-hip-write would appriciate a review on this, the CUDA/HIP changes are very small. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA/HIP 👍
1c7d0c7
to
d2cc130
Compare
d2cc130
to
c409f71
Compare
f5ea371
to
c409f71
Compare
884367b
to
1db31e7
Compare
I've removed ready to merge since the CUDA checks aren't passing, please add it again once they go green. |
1db31e7
to
acb3dda
Compare
acb3dda
to
938c533
Compare
Also attempt to clarify the wording around this a bit. Addresses oneapi-src#558
938c533
to
5698e57
Compare
oneapi-src/unified-runtime#805 --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Also attempt to clarify the wording around this a bit.
fixes #558
LLVM testing intel/llvm#12270