Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix device binary extension for nvptx #847

Closed
wants to merge 1 commit into from
Closed

Fix device binary extension for nvptx #847

wants to merge 1 commit into from

Conversation

fabiomestre
Copy link
Contributor

No description provided.

@fabiomestre fabiomestre marked this pull request as ready for review September 4, 2023 12:37
aarongreig
aarongreig reviewed Sep 4, 2023
View reviewed changes
test/conformance/device_code/CMakeLists.txt
set(EXTENSION ".bin")
endif()

set(EXE_PATH "${DEVICE_BINARY_DIR}/${KERNEL_NAME}_${TRIPLE}${EXTENSION}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dpcxx command below doesn't output IR, it results in an executable which is then run to get the IR to dump

@fabiomestre fabiomestre marked this pull request as draft September 4, 2023 13:04
pbalcer
pbalcer reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for when there is more than one triplet specified? The current script does work on CI when there's only one triplet set.

@fabiomestre
Copy link
Contributor Author

Is this for when there is more than one triplet specified? The current script does work on CI when there's only one triplet set.

Is this for when there is more than one triplet specified? The current script does work on CI when there's only one triplet set.

Yeah, it seems that this was working as intented. I just misunderstood how the ptx is being generated. I will close this PR

@fabiomestre fabiomestre closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongreig aarongreig aarongreig left review comments

@pbalcer pbalcer pbalcer left review comments

@veselypeta veselypeta veselypeta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabiomestre @pbalcer @aarongreig @veselypeta