[UR] [CUDA] Changed the output of querying localMemSize #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding PR in intel/llvm: intel/llvm#11454 |
|
LGTM |
hdelan
approved these changes
Oct 12, 2023
konradkusiak97
force-pushed
the
konradkusiak/LocalMemSizeQuery
branch
from
b19e090
to
9cbd2ef
Compare
JackAKirk
approved these changes
Oct 24, 2023
|
Yes, I'll adjust the documentation once this is in |
kbenzie
requested changes
Nov 3, 2023
There was a problem hiding this comment.
@konradkusiak97 please fix the conflict in source/adapters/cuda/enqueue.cpp
konradkusiak97
force-pushed
the
konradkusiak/LocalMemSizeQuery
branch
2 times, most recently
from
692f2d7
to
66287b1
Compare
mmoadeli
reviewed
Nov 3, 2023
mmoadeli
reviewed
Nov 3, 2023
konradkusiak97
force-pushed
the
konradkusiak/LocalMemSizeQuery
branch
from
ac43166
to
d5a4691
Compare
kbenzie
approved these changes
Nov 3, 2023
mmoadeli
approved these changes
Nov 3, 2023
dm-vodopyanov
pushed a commit
to intel/llvm
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch when the user asks for the amount of
localMemSize, they receive the maximum amount available on the SM. Setting the maximum limit with the env variable still remains an option.