Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXP][CMDBUF] Implement Fill commands for L0 adapter #938

Merged
merged 10 commits into from
Jan 4, 2024
Merged

[EXP][CMDBUF] Implement Fill commands for L0 adapter #938

merged 10 commits into from
Jan 4, 2024

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Oct 9, 2023 •
edited
Loading

Note: This PR also includes changes from the main branch (commit 40a6846) which add these commands to the UR specification, but are not present in the adapter branch yet.

  • Adds implementation of command-buffer fill commands for the L0 adapter.
  • Includes stubs for the CUDA and HIP adapters.

@Bensuo
Copy link
Contributor Author

Bensuo commented Oct 9, 2023

Linked Intel/LLVM PR: intel/llvm#11472

jandres742
jandres742 reviewed Oct 10, 2023
View reviewed changes
Copy link

@jandres742 jandres742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looking good from L0 side

@Bensuo Bensuo changed the title [EXP]{CMDBUF] Implement Fill commands for L0 adapter [EXP][CMDBUF] Implement Fill commands for L0 adapter Oct 10, 2023
@Bensuo Bensuo force-pushed the cmdbuf-fill-memset-l0 branch 2 times, most recently from 3756625 to e56aeb6 Compare October 31, 2023 12:09
@mfrancepillois mfrancepillois force-pushed the cmdbuf-fill-memset-l0 branch 2 times, most recently from 6047a34 to 187e34d Compare December 1, 2023 16:07
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d8173a) 15.73% compared to head (3ee71a7) 15.74%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   15.73%   15.74%           
=======================================
  Files         223      223           
  Lines       31478    31477    -1     
  Branches     3558     3558           
=======================================
+ Hits         4954     4956    +2     
+ Misses      26473    26471    -2     
+ Partials       51       50    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiomestre fabiomestre changed the base branch from adapters to main December 5, 2023 16:54
@fabiomestre
Copy link
Contributor

I have updated the target branch of this PR from the adapters branch to the main branch.
Development in UR is moving back to main. The adapters branch will soon be deleted.

@mfrancepillois
Copy link
Contributor

This PR was rebased after the main branch was merged with adapter branch.
We also added the support for CUDA backend.

@mfrancepillois mfrancepillois marked this pull request as ready for review December 6, 2023 17:47
@mfrancepillois mfrancepillois requested review from a team as code owners December 6, 2023 17:47
@EwanC
Copy link
Contributor

EwanC commented Dec 8, 2023

changes looking good from L0 side

Could you hit approve on this @jandres742 if you are still happy

mmoadeli
mmoadeli approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@mmoadeli mmoadeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuda / hip LGTM

@EwanC
Copy link
Contributor

EwanC commented Dec 11, 2023

@nrspruit could you review on behalf of @oneapi-src/unified-runtime-level-zero-write

martygrant
martygrant approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@martygrant martygrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenCL LGTM

@EwanC EwanC mentioned this pull request Dec 12, 2023
Merged
nrspruit
nrspruit approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Level Zero.

@EwanC EwanC added the ready to merge Added to PR's which are ready to merge label Dec 19, 2023
@Bensuo @EwanC
[CMDBUF] Add fill commands to cmd buffer exp feature
557a3a1 
- Adds USM and Buffer fill append commands
- Update feature spec for new commands
- Align naming conventions for Append* commands with core equivalents
- Also includes stubs for CUDA and HIP adapters
@Bensuo @EwanC
Add OpenCL fill stubs and fix naming
3c4d445
@kbenzie kbenzie merged commit 1d78636 into oneapi-src:main Jan 4, 2024
51 checks passed
kbenzie added a commit to kbenzie/llvm that referenced this pull request Jan 4, 2024
@kbenzie
[UR] Bump tag to 1d786360
328c071 
* oneapi-src/unified-runtime#937
* oneapi-src/unified-runtime#938
@kbenzie kbenzie mentioned this pull request Jan 4, 2024
Merged
dm-vodopyanov pushed a commit to intel/llvm that referenced this pull request Jan 4, 2024
@kbenzie
[UR] Bump tag to 1d786360 (#12292)
a71355c 
* oneapi-src/unified-runtime#937
* oneapi-src/unified-runtime#938
@EwanC EwanC mentioned this pull request Jan 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrancepillois mfrancepillois mfrancepillois left review comments

@jandres742 jandres742 jandres742 left review comments

@martygrant martygrant martygrant approved these changes

@nrspruit nrspruit nrspruit approved these changes

@EwanC EwanC EwanC approved these changes

@mmoadeli mmoadeli mmoadeli approved these changes

Assignees
No one assigned
Labels
ready to merge Added to PR's which are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Bensuo @codecov-commenter @fabiomestre @mfrancepillois @EwanC @mmoadeli @nrspruit @jandres742 @martygrant @kbenzie