[HIP][CUDA] Change unions in ur_mem_handle_t_ to stdvariant #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
intel/llvm testing: intel/llvm#11539 |
jchlanda
approved these changes
Oct 17, 2023
|
@kbenzie can we merge this please? |
We already have 2 UR changes that can't merge to intel/llvm because of test failures, I feel like merging this will only add to that problem. |
|
@kbenzie OK sure yes no rush |
hdelan
force-pushed
the
change-unions-to-stdvariant
branch
from
2b2e234
to
86f96f0
Compare
EwanC
added a commit
to Bensuo/unified-runtime
that referenced
this pull request
Oct 30, 2023
This is required after oneapi-src#961
againull
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 30, 2023
Update UR SHA to oneapi-src/unified-runtime#961 change unions to std::variant in the HIP and CUDA adapters. --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie83@gmail.com>
maarquitos14
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 31, 2023
Update UR SHA to oneapi-src/unified-runtime#961 change unions to std::variant in the HIP and CUDA adapters. --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie83@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Std::variant is safer than unions in the
ur_mem_handle_t_class and it will make it easier to incrementally move to multi device ctx, which requires addingstd::vectors to the MemImpl, which is not possible in a union.